Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Sparse Matrices #27

Draft
wants to merge 76 commits into
base: main
Choose a base branch
from
Draft

Support for Sparse Matrices #27

wants to merge 76 commits into from

Conversation

samuelsonric
Copy link
Collaborator

@samuelsonric samuelsonric commented Nov 21, 2024 •
edited
Loading

  • Constructors take adjacency matrices as inputs.
  • ordered graphs stored as (sparse) adjacency matrices -- 10x performance improvement!
  • Pretty printing

@samuelsonric samuelsonric marked this pull request as draft November 22, 2024 03:03
@samuelsonric
renamed variable
02c6e30
@samuelsonric
tests passing
927470e
@samuelsonric
elimination trees gone
68ee1cb
@samuelsonric
tests passing somehow
39f9da0
@samuelsonric
removed type SupernodeTree
f5115d6
@samuelsonric
removed graph from jtree
763552f
@samuelsonric
renamed variables
aa612fe
@samuelsonric
added some docstrings
6518848
@samuelsonric
removed degrees
9c68ef6
@samuelsonric
temp commit
7790f63
@samuelsonric
temp commit
a6fa24e
@samuelsonric
temp commit
695a422
@samuelsonric
performance improvement
61df456
@samuelsonric
fiddled with internals
d96bad7
@samuelsonric
removed function fdesc
be4bb49
@samuelsonric
fixed ne calculation
b5de2d9
@samuelsonric
changed types
b61b0c2
@samuelsonric
printing
97b7839
@samuelsonric
order setindex
772162b
@samuelsonric
temp commit
4808c77
@samuelsonric
tests passing
0243076
@samuelsonric
tiny performance improvement
4dbd44f
@samuelsonric
deleted swp
820345b
@samuelsonric
fixed math
8d6e526
@samuelsonric
pointless changes
0330446
@samuelsonric
performance improvement during symbolic factorization
4739181
@samuelsonric
removed unused files
cc8e887
@samuelsonric
removed commented code
d1a182b
@samuelsonric
seperate data structures.
9d09828
@codecov Codecov
Copy link

codecov bot commented Dec 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.17201% with 44 lines in your changes missing coverage. Please review.

Project coverage is 84.11%. Comparing base (2549aa4) to head (9d09828).

Files with missing lines Patch % Lines
src/junction_trees/abstract_ordered_graphs.jl 0.00% 11 Missing ⚠️
src/junction_trees/junction_trees.jl 89.15% 9 Missing ⚠️
src/junction_trees/ordered_graphs.jl 90.47% 6 Missing ⚠️
src/junction_trees/trees.jl 83.78% 6 Missing ⚠️
src/junction_trees/fixed_stacks.jl 71.42% 4 Missing ⚠️
src/junction_trees/elimination_algorithms.jl 93.33% 3 Missing ⚠️
src/junction_trees/child_indices.jl 84.61% 2 Missing ⚠️
src/junction_trees/orders.jl 80.00% 2 Missing ⚠️
src/junction_trees/postorder_trees.jl 96.42% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
- Coverage   87.15%   84.11%   -3.04%     
==========================================
  Files          14       16       +2     
  Lines         654      680      +26     
==========================================
+ Hits          570      572       +2     
- Misses         84      108      +24

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@samuelsonric